Require orm ^2.11 and adapt cache implementation #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With doctrine/orm 2.11.0 the internal implementation of caches has slightly changed, a PSR6 adapter is now wrapped around all caches. This fixes the resulting CI errors.
snapshotpl
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With orm ^2.11, cache adapters are always wrapped in a PSR6 object. This has caused issues with our CI pipeline in #708 and #709.
This PR upgrades orm to ^2.11.1 and changes unit tests to fix all CI errors. Targeted at the 4.2.x branch, which currently is still maintained.